Change how "Get Z value from project terrain" tool is presented in Mesh Editing #60709
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Co-authored-by: Stefanos Natsis <[email protected]>
Co-authored-by: Stefanos Natsis <[email protected]>
Co-authored-by: Stefanos Natsis <[email protected]>
|
@JanCaha Thanks for the follow-up
Hum... The comment you are referring to was instead agreeing to add the option to the Z widget 🤔
So that means a user can enter value for X, Y and check "Get Z value from terrain" at the same time? Then, when is the Z value picked from the terrain: at the initial position (before moving xy), or after the move is done? We should clarify this in the GUI IMHO (and for docs). Would you know why "Apply transform" is disabled in the screenshot? |
There was a problem hiding this comment.
So that means a user can enter value for X, Y and check "Get Z value from terrain" at the same time?
Yes.
Then, when is the Z value picked from the terrain: at the initial position (before moving xy), or after the move is done? We should clarify this in the GUI IMHO (and for docs).
It doesn't really make much sense to get the z from the initial position, however we could clarify that on a tooltip
Would you know why "Apply transform" is disabled in the screenshot?
Apply transform is enabled after preview is clicked
| if ( vertexTransformed ) | ||
| { |
There was a problem hiding this comment.
Hmmm, I wonder if it is safe to skip vertices that failed the transform, or if mNewZValues needs to be matching mNewXYValues in size and we should just return false on exception.
| if ( mZFromTerrain ) | ||
| { | ||
| if ( terrainProvider ) | ||
| { |
There was a problem hiding this comment.
Group those two?
if ( mZFromTerrain && terrainProvider )
{|
|
||
| try | ||
| { | ||
| point = transformation.transform( vert.x(), vert.y() ); |
There was a problem hiding this comment.
Harissou has a point, if calcX || calcY we should be transforming mNewXYValues.constLast() instead
| this method not apply new vertices to the mesh layer but only store the calculated transformation | ||
| that can be apply later with :py:func:`QgsMeshEditor.advancedEdit()` |
There was a problem hiding this comment.
I don't know if this is public API, but anyway, could you update these sentences while at it, please? Thanks.
This method does not apply new vertices to the mesh layer but only stores the calculated transformation
that can be applied later with :py:func:`QgsMeshEditor.advancedEdit()`
Description
Changed the way how Get Z value from project terrain is presented to the user according to #60512 (comment).
The Z Value and Get Z value from project terrain checkboxes are mutually exclusive, so user can either select one or the other.
Works with both Preview Transform and Apply Transform.